Add ResourceRequirments to WorkflowController

gmfrasca commented 5 months ago

Introduces ResourceRequirements for WorkflowController in DSPA CRD
Adds dynamic request and limit defaults for WC deployment

The issue resolved by this Pull Request:

Resolves RHOAIENG-8242

Description of your changes:

Testing instructions

Deploy DSPO
Create DSPA, preferably with custom values set for spec.workflowController.resources.requests.memory, spec.workflowController.resources.limits.memory, spec.workflowController.resources.requests.cpu, and spec.workflowController.resources.limits.cpu
Go to OpenShift Console, go to DSPA project, and click Pods
Find pod with name starting with ds-pipeline-workflow-controller- and click it
Go to Metrics tab, ensure the Memory Usage and CPU Usage graphs show correct limits
Run several simultaneous pipelines, ensure the limits are not encroached upon

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 5 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-667 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/667/head
git checkout -b pullrequest 00ae75c614be8531149f3fa438f5707d7e0a5aa5
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-667"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 5 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-667

HumairAK commented 5 months ago

/lgtm /approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / data-science-pipelines-operator