opendatahub-io / data-science-pipelines-operator

Apache License 2.0
13 stars 55 forks source link

Expose API Server and Envoy endpoints and add a new Envoy condition #669

Closed rimolive closed 3 months ago

rimolive commented 5 months ago

The issue resolved by this Pull Request:

Resolves RHOAIENG-7929

Description of your changes:

This PR will introduce a new condition to check if MLMD Envoy is ready (EnvoyReady) and add the DSPA endpoints (API Server and MLMD Envoy) to the status field.

Testing instructions

Checklist

dsp-developers commented 4 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

rimolive commented 4 months ago

Removed all occurrences of EnvoyReady and replaced by MLMDProxyReady

dsp-developers commented 4 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 4 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 4 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

rimolive commented 3 months ago

/hold

Found a nitpick issue, will work on a fix.

rimolive commented 3 months ago

/unhold

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

gregsheremeta commented 3 months ago

/lgtm

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

gregsheremeta commented 3 months ago

/lgtm

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [gmfrasca] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gregsheremeta commented 3 months ago

/lgtm /approve