opendatahub-io / data-science-pipelines-operator

Apache License 2.0
11 stars 47 forks source link

increase default expiry for signed url #676

Closed HumairAK closed 1 month ago

HumairAK commented 1 month ago

Increase expiry for signed url to recommended minimum from aws s3

dsp-developers commented 1 month ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-676 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/676/head
git checkout -b pullrequest 025289faa4d77863b3ca15be26e85dd0d82faa6c
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-676"

More instructions here on how to deploy and test a Data Science Pipelines Application.

gregsheremeta commented 1 month ago

A presigned URL remains valid for the period of time specified when the URL is generated. If you create a presigned URL with the Amazon S3 console, the expiration time can be set between 1 minute and 12 hours.

ref: https://docs.aws.amazon.com/AmazonS3/latest/userguide/using-presigned-url.html

and we've seen it be unreliable below 60 seconds. Suspect on-prem kubernetes node clocks not matching up with AWS clocks or something like that.

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [gregsheremeta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-676