Disable DSPO Debug Logs by Default and modify the "DSPA resource was not found" message to Debug - Githubissues

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

11 stars 47 forks source link

Disable DSPO Debug Logs by Default and modify the "DSPA resource was not found" message to Debug #678

Closed amadhusu closed 1 month ago

amadhusu commented 1 month ago

The issue resolved by this Pull Request:

Resolves RHOAIENG-1650

Description of your changes:

When deleting a DSPA we continue to see these types of logs:

2023-08-23T17:17:40Z DEBUG Reconcile event triggered by [Pod: mariadb-pipelines-definition-6d848d8d75-hg6hq] {"namespace": "my-ds-project"}
2023-08-23T17:17:40Z DEBUG Reconcile event triggered by [Pod: mariadb-pipelines-definition-6d848d8d75-hg6hq] {"namespace": "my-ds-project"}
2023-08-23T17:17:40Z DEBUG DataSciencePipelinesApplication Reconciler called. {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"}
2023-08-23T17:17:40Z INFO DSPA resource was not found {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"}
2023-08-23T17:17:40Z DEBUG Reconcile event triggered by [Pod: mariadb-pipelines-definition-6d848d8d75-hg6hq] {"namespace": "my-ds-project"}
2023-08-23T17:17:40Z DEBUG DataSciencePipelinesApplication Reconciler called. {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"}
2023-08-23T17:17:40Z INFO DSPA resource was not found {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"}
2023-08-23T17:17:40Z DEBUG DataSciencePipelinesApplication Reconciler called. {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"}
2023-08-23T17:17:40Z INFO DSPA resource was not found {"namespace": "my-ds-project", "dspa_name": "pipelines-definition"

This PR resolves this by ensuring DSPO logs default to Debug logs with the first commit. The second commit modifies the "DSPA resources was not found" message to a Debug instead of an Info.

Testing instructions

Deploy the DSPO created by Github
Deploy DSPA
(Optional) Deploy additional DSPA in another namespace
Delete the original DSPA
Observe the DSPO logs to ensure that "DEBUG DSPA resource was not found" does not appear

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 1 month ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/678/head
git checkout -b pullrequest bd8b98f0fcf548b0adb3ae855cc78f6fe14a90e1
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-678"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-678

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: diegolovison Once this PR has been reviewed and has the lgtm label, please assign accorvin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

diegolovison commented 1 month ago

/lgtm

VaniHaripriya commented 1 month ago

/verified Tested as per instructions and I could see only the info logs. Attaching the logs for reference(appropriate logs from line 950)data-science-pipelines-operator-controller-manager-d86cdf7tfpbx-manager.log

HumairAK commented 1 month ago

/hold

gregsheremeta commented 1 month ago

gonna split this up into separate tasks

gregsheremeta commented 1 month ago

/close

openshift-ci[bot] commented 1 month ago

@gregsheremeta: Closed this PR.

In response to [this](https://github.com/opendatahub-io/data-science-pipelines-operator/pull/678#issuecomment-2274033111): >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.