opendatahub-io / data-science-pipelines-operator

Apache License 2.0
12 stars 49 forks source link

Clarify the "DSPA not found" log message that happens when a DSPA is deleted #682

Closed gregsheremeta closed 3 months ago

gregsheremeta commented 3 months ago

The issue resolved by this Pull Request:

n/a

Description of your changes:

Clarify the "DSPA not found" log message that happens when a DSPA is deleted

Testing instructions

n/a

Checklist

dsp-developers commented 3 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-682 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/682/head
git checkout -b pullrequest 8f7fabc640d52318a70e1b49a6e9e72a5533e81c
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-682"

More instructions here on how to deploy and test a Data Science Pipelines Application.

HumairAK commented 3 months ago

/lgtm /approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment