UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server

hbelmiro commented 1 month ago

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-4971

This PR depends on:

https://github.com/opendatahub-io/data-science-pipelines/pull/72

Description of the changes:

Added support for TLS to MLMD GRPC Server

Testing instructions

There are 2 scenarios for testing:

TLS Enabled

1. Deploy the following DSPA ```yaml apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1 kind: DataSciencePipelinesApplication metadata: name: dspa spec: dspVersion: v2 podToPodTLS: true apiServer: image: "quay.io/opendatahub/ds-pipelines-api-server:pr-72" argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-72" argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-72" enableSamplePipeline: true persistenceAgent: image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72" scheduledWorkflow: image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72" mlmd: deploy: true # Optional component grpc: image: "quay.io/opendatahub/mlmd-grpc-server:latest" envoy: image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2" mlpipelineUI: deploy: true # Optional component image: "quay.io/opendatahub/ds-pipelines-frontend:pr-72" objectStorage: minio: deploy: true image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' ``` 2. Run the sample pipeline 3. The run must complete successfully

TLS Disabled

1. Deploy the following DSPA ```yaml apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1 kind: DataSciencePipelinesApplication metadata: name: dspa spec: dspVersion: v2 podToPodTLS: false apiServer: image: "quay.io/opendatahub/ds-pipelines-api-server:pr-72" argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-72" argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-72" enableSamplePipeline: true persistenceAgent: image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72" scheduledWorkflow: image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72" mlmd: deploy: true # Optional component grpc: image: "quay.io/opendatahub/mlmd-grpc-server:latest" envoy: image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2" mlpipelineUI: deploy: true # Optional component image: "quay.io/opendatahub/ds-pipelines-frontend:pr-72" objectStorage: minio: deploy: true image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' ``` 2. Run the sample pipeline 3. The run must complete successfully

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 1 month ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-683 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/683/head
git checkout -b pullrequest 85a6ca9ebb69f28e05780de54509b0d3855cb533
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-683"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 2 weeks ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-683

VaniHaripriya commented 1 week ago

/verified /lgtm Deployed DSPO and verified the two scenarios mentioned in the testing instructions. Created pipeline runs and they completed successfully.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dsp-developers commented 1 week ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-683

dsp-developers commented 1 week ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-683

dsp-developers commented 1 week ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-683

opendatahub-io / data-science-pipelines-operator