search

opendatahub-io / data-science-pipelines-operator

Apache License 2.0
12 stars 49 forks source link

make mlmd grpc NP more permissive #688

Closed HumairAK closed 2 months ago

HumairAK commented 2 months ago

pipeline server also needs to be able to communicate with mlmd, making this NP more permissible to avoid any other unforseen issues, this will allow all dsp component pods to communicate with mlmd grpc server

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsp-developers commented 2 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-688 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/688/head
git checkout -b pullrequest aa95bfa7965335ee67e1618b39684d3316dc10b0
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-688"

More instructions here on how to deploy and test a Data Science Pipelines Application.