Removed imagePullPolicy: IfNotPresent

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

13 stars 55 forks source link

Removed imagePullPolicy: IfNotPresent #697

Closed hbelmiro closed 2 months ago

hbelmiro commented 3 months ago

Resolves: https://issues.redhat.com/browse/RHOAIENG-12336

This PR changes imagePullPolicy for default instead of IfNotPresent.

Testing instructions

Deploy the simple-dspa sample and run the pipeline. The run must succeed.

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 3 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-697 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/697/head
git checkout -b pullrequest a726e3c78652ad780457f1d96d282480634a6f0d
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-697"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-697

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-697

gregsheremeta commented 3 months ago

/lgtm

HumairAK commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment