Improve documentation for tLSClientConfig

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

13 stars 55 forks source link

Improve documentation for tLSClientConfig #700

Closed diegolovison closed 3 weeks ago

diegolovison commented 2 months ago

Description of your changes:

GoDoc-style comment for your tLSClientConfig function

Testing instructions

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

VaniHaripriya commented 2 months ago

/lgtm

DharmitD commented 4 weeks ago

/hold

DharmitD commented 4 weeks ago

Put a hold on merging due to CI failure: https://github.com/opendatahub-io/data-science-pipelines-operator/actions/runs/10835954834/job/30068595888?pr=700

but the failure isn't related to this PRs updates.

/unhold /Approve

dsp-developers commented 4 weeks ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-700

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [DharmitD] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment