Move kind-integration.sh content to tests.sh and target environment for testing

diegolovison commented 2 months ago

The issue resolved by this Pull Request:

Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.

Description of your changes:

The goal of test.sh is to be the starting point for allowing a test to be running to the following target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.

How to review:

The content of kind-integration.sh was copied to test.sh
Functions were created into test.sh
A new way to call the script was created sh tests.sh --kind
In the next PR, we are introducing the --openshift parameter and implementation

Why this should be merged

No manual testing is required
Defined a new way to call the script that will be the base for --openshift. Having the base well defined and agreement from the team we can move forward and avoid rework. There are multiple ways to create a bash script and we should use one that the team is more comfortable with.

Questions

Explain the targets and the difference: target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.
- kind: The script will create all namespaces and set up all required dependencies. Example: routes, CRDs,
- Fresh OpenShift: The script will ( next PR ) create all namespaces required but will skip Routes ( OpenShift native ). It will also install the required dependencies.
- OpenShift cluster with RHOAI installed: It won't install namespaces, routes, or CRDs. It will install only required depedencies.
- - All the 3 options above are setup related things, after the setup, the test will run. The test code is the same for all the 3 install options above.

Testing instructions

If GHA action passes, all good. No manual testing is required.

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

HumairAK commented 2 months ago

/approve

will let @rimolive lgtm it

HumairAK commented 2 months ago

/hold

rimolive commented 2 months ago

/lgtm

HumairAK commented 2 months ago

/unhold /lgtm

rimolive commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK,rimolive] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / data-science-pipelines-operator