Reuse WaitFor function to ensure DSPA is ready

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

13 stars 54 forks source link

Reuse WaitFor function to ensure DSPA is ready #714

Closed diegolovison closed 1 month ago

diegolovison commented 1 month ago

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-10212

Description of your changes:

Support --endpoint-type and refactor the test suite to allow reusing the WaitFor function

Testing instructions

kind: No manual testing required. rhoai: sh run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG -i ODS-2632' --skip-oclogin ( it passed )

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

@diegolovison: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-test-odh-dspo	14d65306450465c4827cc39cae134d706747c809	link	true	`/test integration-test-odh-dspo`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

HumairAK commented 1 month ago

nicely done! /lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, jgarciao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment