Added secrets::list permissions to pipeline runner

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

13 stars 54 forks source link

Added secrets::list permissions to pipeline runner #715

Closed diegolovison closed 1 month ago

diegolovison commented 1 month ago

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-13630

Description of your changes:

Added secrets::list permissions to pipeline runner

Testing instructions

Run a Ray Integration pipeline

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 1 month ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-715 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/715/head
git checkout -b pullrequest 026f94582c96d500acf18e9d30b82ec31bdeb968
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-715"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-715

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-715

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-715

openshift-ci[bot] commented 1 month ago

@diegolovison: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-test-odh-dspo	2e3409fed19f47928d26dec841c1b7feb5df5e2a	link	true	`/test integration-test-odh-dspo`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

HumairAK commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment