Open HumairAK opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-728
Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-728
/lgtm
PR needs rebase.
Is it possible to have a test for this?
This will handle the following dspo log message more gracefully:
This is an expected state, and should not print a stack trace, but we still want to stacktrace other errors. So I've introduced a custom error for this scenario. In the future we should handle this via states for components, for example "state: loading" or "state: waitingOnDependency", instead of errors, but this should be approached consistently for all components, this pr is a simple fix until then.
Result: