search

opendatahub-io / data-science-pipelines-operator

Apache License 2.0
13 stars 54 forks source link

correct pa config path #730

Closed HumairAK closed 1 month ago

HumairAK commented 1 month ago

this will match the config path to what we are specifying for env vars for the pa image found in config/base/params.env i.e. IMAGES_PERSISTENCEAGENT should match Images.PersistenceAgent

gregsheremeta commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [gregsheremeta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsp-developers commented 1 month ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/730/head
git checkout -b pullrequest ebab2e1f78611a0458c72724c52a7cf3ef05c9a3
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-730"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730

VaniHaripriya commented 1 month ago

Please take a look at the failed Integration test.

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730

dsp-developers commented 1 month ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-730