Removed comment from MLMD gRPC server config

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

13 stars 54 forks source link

Removed comment from MLMD gRPC server config #749

Closed hbelmiro closed 2 weeks ago

hbelmiro commented 2 weeks ago

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-15689 (Along with https://github.com/opendatahub-io/data-science-pipelines-operator/pull/742)

Description of your changes:

This PR removes a comment incompatible with the MLMD gRPC server config syntax.

Testing instructions

This was tested by @jgarciao in a cluster.

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dsp-developers commented 2 weeks ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-749 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/749/head
git checkout -b pullrequest 9ca772569af473a1fb80af3711729461ef3193bc
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-749"

More instructions here on how to deploy and test a Data Science Pipelines Application.

jgarciao commented 2 weeks ago

LGTM

gregsheremeta commented 2 weeks ago

I would have been tempted to put the comment higher up as a yaml comment, but nbd

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [gregsheremeta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment