opendatahub-io / data-science-pipelines-tekton

Kubeflow Pipelines on Tekton
https://developer.ibm.com/blogs/kubeflow-pipelines-with-tekton-and-watson/
Apache License 2.0
0 stars 19 forks source link

GitHub Image Build Actions #182

Closed gmfrasca closed 10 months ago

gmfrasca commented 11 months ago

Which issue is resolved by this Pull Request: Resolves #119

Description of your changes: It is difficult to verify these in-line because the workflows need to be in master to apply. Therefore, i have several examples found on my personal fork which can be reviewed:

Pushes to master: https://github.com/gmfrasca/data-science-pipelines/actions/workflows/build-master.yml Manually Run: https://github.com/gmfrasca/data-science-pipelines/actions/workflows/build-images.yaml PR Opened/Closed: https://github.com/gmfrasca/data-science-pipelines/actions/workflows/build-prs.yml

For the PR action, verify that the opened and closed workflows both look acceptable: Opened: https://github.com/gmfrasca/data-science-pipelines/actions/runs/6910582791 Closed: https://github.com/gmfrasca/data-science-pipelines/actions/runs/6910720341*

*the single failure was expected - a specific image was manually deleted before running

Environment tested: N/A

Checklist:

HumairAK commented 10 months ago

/lgtm /approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines/blob/master/OWNERS)~~ [HumairAK,gmfrasca] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment