Closed VedantMahabaleshwarkar closed 1 month ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: VedantMahabaleshwarkar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
We also should update the storage initializer one.
We also should update the storage initializer one.
If I am not mistake, custo_transformers and custom_model as well.
We also should update the storage initializer one.
@israel-hdez added the storage initializer dockerfile as well.
We also should update the storage initializer one. If I am not mistake, custo_transformers and custom_model as well.
@spolti doesn't look like we use/build those today https://github.com/opendatahub-io/kserve/blob/master/config/overlays/odh/params.env
@spolti @Jooho all comments are addressed. PTAL
/retest-required
@VedantMahabaleshwarkar: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-slow | d2c26b721a08040eb3aed5510187b5842fa048d3 | link | true | /test e2e-slow |
ci/prow/e2e-fast | d2c26b721a08040eb3aed5510187b5842fa048d3 | link | true | /test e2e-fast |
Full PR test history. Your PR dashboard.
@Jooho I checked the CI failures, the failure is not in the test. The destroy-cluster
sub step timed out after the test was successful. The ci failure can be ignored. PTAL.
ci-fast show test passed but full ci failed
INFO[2024-05-30T18:59:12Z] Running step e2e-fast-e2e-fast.
WARN[2024-05-30T19:16:52Z] Failed to get namespace ci-op-zvy0gbrz for heartbeating error=Get "[https://172.30.0.1:443/api/v1/namespaces/ci-op-zvy0gbrz](https://172.30.0.1/api/v1/namespaces/ci-op-zvy0gbrz)": http2: client connection lost
INFO[2024-05-30T19:18:34Z] Step e2e-fast-e2e-fast succeeded after 19m21s.
INFO[2024-05-30T19:18:34Z] Step phase test succeeded after 19m21s.
ci-slow show test passed but full ci failed
INFO[2024-05-30T19:09:18Z] Step e2e-slow-e2e-slow succeeded after 10m4s.
INFO[2024-05-30T19:09:18Z] Step phase test succeeded after 10m4s.
So I think we should ignore the ci failure.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes https://issues.redhat.com/browse/RHOAIENG-6506Note: Replaced existing Dockerfiles because that file is what Konflux uses to build the images. Also, this will help track any changes to the upstream dockerfile because it will create a merge-conflict (as opposed to maintaining a separate
Dockerfile.ubi8` file).Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced. Please also list any relevant details for your test configuration.
podman build
succeeds locally.