search

opendatahub-io / kubeflow

Machine Learning Toolkit for Kubernetes
Apache License 2.0
10 stars 32 forks source link

What happens when OpenShift API library is updated to github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd? #361

Open jiridanek opened 3 months ago

jiridanek commented 3 months ago

/kind question

Question:

What happens when OpenShift API library is updated from

github.com/openshift/api v0.0.0-20190924102528-32369d4db2ad

to

github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd

?

Answer:

 2024-06-28T17:34:36Z   ERROR   controllers.notebook-controller Unable to create the Route  {"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z    ERROR   Reconciler error    {"controller": "notebook", "controllerGroup": "kubeflow.org", "controllerKind": "Notebook", "Notebook": {"name":"test-notebook","namespace":"default"}, "namespace": "default", "name": "test-notebook", "reconcileID": "f06ee7fb-f9ad-4553-a07b-3bf3bc7009ba", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z    INFO    controllers.notebook-controller Creating Route  {"notebook": "test-notebook", "namespace": "default"}
2024-06-28T17:34:36Z    ERROR   controllers.notebook-controller Unable to create the Route  {"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
    /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227

And what happens when the latest version is used? Package does not compile on go1.21 and go1.22 is needed.

openshift-ci[bot] commented 3 months ago

@jiridanek: The label(s) kind/question cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/opendatahub-io/kubeflow/issues/361): >/kind question > >**Question:** > >What happens when OpenShift API library is updated from > >github.com/openshift/api v0.0.0-20190924102528-32369d4db2ad > >to > >github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd > >? > >**Answer:** > >``` > 2024-06-28T17:34:36Z ERROR controllers.notebook-controller Unable to create the Route {"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"} >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104 >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145 >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227 >2024-06-28T17:34:36Z ERROR Reconciler error {"controller": "notebook", "controllerGroup": "kubeflow.org", "controllerKind": "Notebook", "Notebook": {"name":"test-notebook","namespace":"default"}, "namespace": "default", "name": "test-notebook", "reconcileID": "f06ee7fb-f9ad-4553-a07b-3bf3bc7009ba", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"} >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:329 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227 >2024-06-28T17:34:36Z INFO controllers.notebook-controller Creating Route {"notebook": "test-notebook", "namespace": "default"} >2024-06-28T17:34:36Z ERROR controllers.notebook-controller Unable to create the Route {"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"} >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104 >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145 >github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile > /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266 >sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 > /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227 >``` > >And what happens when the latest version is used? Package does not compile on go1.21 and go1.22 is needed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.