Add support for USE_ISTIO flag in odh-notebook-controller

opendatahub-io / kubeflow

Machine Learning Toolkit for Kubernetes

Apache License 2.0

10 stars 33 forks source link

Add support for USE_ISTIO flag in odh-notebook-controller #82

Open VaishnaviHire opened 1 year ago

VaishnaviHire commented 1 year ago

/kind feature

The current implementation do not support USEE_ISTIO flag used by the Kubeflow controller.
Notebook resources created with an annotation/label/other (e.g. istio=true) should generate and manage notebook resources to use Service Mesh instead of the routes and oauth-proxy sidecars

maroroman commented 1 year ago

@VaishnaviHire I imagine I could copy the functionality in the notebook-controller component for this? Also what would be the best way to test this, should the nbc just add a sidecar.istio.io/inject="true" to every notebook if USE_ISTIO is enabled and istio is deployed?

VaishnaviHire commented 1 year ago

As discussed, this is dependent on the implementation to support servicemesh in ODH. The goal for this change is to make sure odh-notebook-controller uses existing gateway instead of adding oauth-proxy sidecar