opendatahub-io / manifests

A repository for Kustomize manifests
Apache License 2.0
8 stars 21 forks source link

Test KF 1.6 on OpenShift #101

Closed VaishnaviHire closed 2 years ago

VaishnaviHire commented 2 years ago

Which issue is resolved by this Pull Request: Resolves #99

Description of your changes:

Testing Instructions:

  1. OCP version - 4.9
  2. Create kubeflow namespace
  3. Deploy manifest using steps given here - https://github.com/opendatahub-io/manifests/blob/5c33ee88a2c4b78cc8fe5ec1eced3233faa204db/openshift/README.md#install-kf-16-on-openshift
VaishnaviHire commented 2 years ago

This PR tests Kubeflow applications with Istio 1.14

cc: @LaVLaS

LaVLaS commented 2 years ago

Just tracking that I recieve the error below running kustomize build openshift/example/istio with kustomize v4.5.5 on a fresh OCP 4.10 cluster

2022/08/22 22:51:59 well-defined vars that were never replaced: VWA_NAMESPACE,bucket-base64,VWA_CLUSTER_DOMAIN,podDefaultsServiceName,CD_CLUSTER_DOMAIN,CD_REGISTRATION_FLOW,CD_USERID_HEADER,JWA_CLUSTER_DOMAIN,kfp-artifact-bucket-name,profile-name,secretAccessKey-bas64,CD_CONFIGMAP_NAME,JWA_PREFIX,JWA_UI,KATIB_CERT_NAME,kfp-default-pipeline-root,namespace,podDefaultsNamespace,JWA_USERID_PREFIX,KATIB_NAMESPACE,VWA_USERID_HEADER,kfp-app-version,podDefaultsCertName,kubelet-path,user,PROFILES_NAMESPACE,clusterDomain,kfp-namespace,KATIB_SERVICE_NAME,KATIB_UI_NAMESPACE,VWA_PREFIX,VWA_USERID_PREFIX,CD_NAMESPACE,CD_USERID_PREFIX,JWA_NAMESPACE,JWA_USERID_HEADER,accessKeyID-base64,endpoint-base64,kfp-app-name,podDefaultsDeploymentName
Error: considering field 'spec/template/spec/containers/*/args/2' of object DaemonSet.v1.apps/istio-cni-node.kube-system: visit traversal on path: [* args 2]: fieldName: *: wildcard is not supported in PathGetter

oc apply -k openshift/example/istio parsed the initial manifest without any issues OC Client Version: 4.10.0-202206270836.p0.g45460a5.assembly.stream-45460a5

VaishnaviHire commented 2 years ago

Just tracking that I recieve the error below running kustomize build openshift/example/istio with kustomize v4.5.5 on a fresh OCP 4.10 cluster

2022/08/22 22:51:59 well-defined vars that were never replaced: VWA_NAMESPACE,bucket-base64,VWA_CLUSTER_DOMAIN,podDefaultsServiceName,CD_CLUSTER_DOMAIN,CD_REGISTRATION_FLOW,CD_USERID_HEADER,JWA_CLUSTER_DOMAIN,kfp-artifact-bucket-name,profile-name,secretAccessKey-bas64,CD_CONFIGMAP_NAME,JWA_PREFIX,JWA_UI,KATIB_CERT_NAME,kfp-default-pipeline-root,namespace,podDefaultsNamespace,JWA_USERID_PREFIX,KATIB_NAMESPACE,VWA_USERID_HEADER,kfp-app-version,podDefaultsCertName,kubelet-path,user,PROFILES_NAMESPACE,clusterDomain,kfp-namespace,KATIB_SERVICE_NAME,KATIB_UI_NAMESPACE,VWA_PREFIX,VWA_USERID_PREFIX,CD_NAMESPACE,CD_USERID_PREFIX,JWA_NAMESPACE,JWA_USERID_HEADER,accessKeyID-base64,endpoint-base64,kfp-app-name,podDefaultsDeploymentName
Error: considering field 'spec/template/spec/containers/*/args/2' of object DaemonSet.v1.apps/istio-cni-node.kube-system: visit traversal on path: [* args 2]: fieldName: *: wildcard is not supported in PathGetter

oc apply -k openshift/example/istio parsed the initial manifest without any issues OC Client Version: 4.10.0-202206270836.p0.g45460a5.assembly.stream-45460a5

Did you get this error in 4.9 cluster as well ?

LaVLaS commented 2 years ago

/lgtm

LaVLaS commented 2 years ago

/approve

VaishnaviHire commented 2 years ago

@LaVLaS Requesting review for KF 1.6 docs changes - https://github.com/kubeflow/website/commit/8b5f61a14baba1908a8bd58113da42dba61a0fac

VaishnaviHire commented 2 years ago

For reference, servicemesh stack updates will be in a separate PR, once this is merged

VaishnaviHire commented 2 years ago

Docs PR : https://github.com/kubeflow/website/pull/3342

LaVLaS commented 2 years ago

Disregard any previous error the KF release only support kustomize v3 and I was using a kustomize v4 binary

https://github.com/kubeflow/manifests/issues/2200#issuecomment-1114149689

VaishnaviHire commented 2 years ago

Branch updated with latest rc - v1.6.0-rc.3

 oc get po -n kubeflow
NAME                                               READY   STATUS    RESTARTS       AGE
admission-webhook-deployment-b878cdc4c-w75vk       1/1     Running   0              60m
cache-deployer-deployment-54d9945778-9d8jk         1/1     Running   0              174m
cache-server-577679d7b9-tq2ts                      1/1     Running   0              174m
centraldashboard-7855dc7958-97rgp                  1/1     Running   0              60m
csi-attacher-s3-0                                  1/1     Running   0              174m
csi-provisioner-s3-0                               1/1     Running   0              174m
jupyter-web-app-deployment-54f9c4f8b6-ss4vt        1/1     Running   0              60m
katib-controller-6848d4dd9f-lt8q2                  1/1     Running   0              174m
katib-db-manager-665954948-xvdbl                   1/1     Running   0              174m
katib-mysql-5bf95ddfcc-9x7br                       1/1     Running   0              174m
katib-ui-56ccff658f-n9mv2                          1/1     Running   0              174m
kfp-csi-s3-jv4tz                                   2/2     Running   0              174m
kfp-csi-s3-vxwpq                                   2/2     Running   0              174m
kfp-csi-s3-zsmms                                   2/2     Running   0              174m
kserve-controller-manager-0                        2/2     Running   0              174m
kserve-models-web-app-544c6b55bb-vh4mc             1/1     Running   0              174m
metadata-envoy-deployment-7b847ff6c5-mvfmv         1/1     Running   0              174m
metadata-grpc-deployment-f8d68f687-fhrgx           1/1     Running   3 (172m ago)   174m
metadata-writer-6b4945489-fzpw7                    1/1     Running   0              174m
minio-5b65df66c9-zfd9k                             1/1     Running   0              174m
ml-pipeline-64bc96bdbd-lzkhj                       1/1     Running   2 (171m ago)   174m
ml-pipeline-persistenceagent-776998878b-g6ftc      1/1     Running   0              174m
ml-pipeline-scheduledworkflow-55fb486f8f-ssm97     1/1     Running   0              174m
ml-pipeline-ui-544c99bc9-6mv4l                     1/1     Running   0              174m
ml-pipeline-viewer-crd-68bdd5f6f5-pc6nq            1/1     Running   0              174m
ml-pipeline-visualizationserver-66979c8f66-jrvcc   1/1     Running   0              174m
mysql-f7b9b7dd4-gbwlz                              1/1     Running   0              174m
notebook-controller-deployment-54f5c68b76-4b6fw    1/1     Running   0              60m
profiles-deployment-567d85d86d-kmzzn               2/2     Running   0              60m
training-operator-6c9f6fd894-rmq58                 1/1     Running   0              36s
volumes-web-app-deployment-5c656c7f-p6bjn          1/1     Running   0              60m

oc get po -n istio-system
NAME                                     READY   STATUS    RESTARTS   AGE
cluster-local-gateway-55ff4696f4-52qvg   1/1     Running   0          174m
istio-ingressgateway-8584f6cbf6-wcjpc    1/1     Running   0          4m2s
istiod-95c7f6cc7-fvfc2                   1/1     Running   0          23m
openshift-ci[bot] commented 2 years ago

New changes are detected. LGTM label has been removed.

LaVLaS commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/manifests/blob/v1.6-branch-openshift/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nachogarciam commented 2 years ago

Hi team!, I was wondering if there is a way to install kf 1.6 but multi user