search

opendatahub-io / manifests

A repository for Kustomize manifests
Apache License 2.0
8 stars 21 forks source link

Add missing permissions to training-operator #109

Closed strangiato closed 1 year ago

strangiato commented 1 year ago

Which issue is resolved by this Pull Request: Resolves #108

Description of your changes: Manually updated the patched ClusterRole to add the missing resources the training-operator requires. This is a good temporary fix but the original patch should probably be replaced with a method that doesn't overwrite the original CR. StrategicMerge will completely replace a list and cannot merge two lists together. If the upstream changes the CR again in the future we will run into the same problem.

Checklist:

openshift-ci[bot] commented 1 year ago

Hi @strangiato. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
strangiato commented 1 year ago

@VaishnaviHire can this get an ok-to-test?

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[openshift/openshiftstack/OWNERS](https://github.com/opendatahub-io/manifests/blob/v1.6-branch-openshift/openshift/openshiftstack/OWNERS)~~ [LaVLaS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
LaVLaS commented 1 year ago

@strangiato fyi: The CI tests for this repo were originally setup for the 1.0 release of kubeflow but will soon be deprecated as we refocus support on specific KF components