search

opendatahub-io / manifests

A repository for Kustomize manifests
Apache License 2.0
8 stars 21 forks source link

Updates to enable PodDefault with ODH #110

Open ykoyfman opened 1 year ago

ykoyfman commented 1 year ago

Which issue is resolved by this Pull Request: Resolves https://github.com/opendatahub-io/kubeflow/issues/61

Description of your changes:

Enable PodDefaults to work after being installed with kustomize build apps/admission-webhook/upstream/overlays/cert-manager | oc apply -f -

Verified environment variables are being injected into notebook pods.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/manifests/blob/v1.6-branch-openshift/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

Hi @ykoyfman. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.