opendatahub-io / manifests

A repository for Kustomize manifests
Apache License 2.0
8 stars 21 forks source link

Adding VS to enable metadata #74

Closed nakfour closed 3 years ago

nakfour commented 3 years ago

Which issue is resolved by this Pull Request: Resolves #https://issues.redhat.com/browse/ODH-475

To test:

  1. install Kubeflow using the manifest from this PR
  2. In kubeflow namespace check for metadata virtual service that it exists
  3. Launch the dashboard, run the example pipeline and check that there is metadata in the artifact tab
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nakfour

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[distributions/stacks/openshift/OWNERS](https://github.com/opendatahub-io/manifests/blob/v1.3-openshift/distributions/stacks/openshift/OWNERS)~~ [nakfour] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
crobby commented 3 years ago

Quick question...what is "VS" as mentioned in the title here?

crobby commented 3 years ago

Quick question...what is "VS" as mentioned in the title here?

Nevermind, I astutely sorted out that VS == VirtualService after actually looking at the code.

VaishnaviHire commented 3 years ago

Tested this successfully. Virtual Service:

 oc get vs/metadata-grpc -n kubeflow     
NAME            GATEWAYS               HOSTS   AGE
metadata-grpc   ["kubeflow-gateway"]   ["*"]   106m

Artifacts:

Screen Shot 2021-09-21 at 1 34 39 PM
VaishnaviHire commented 3 years ago

/lgtm