search

opendatahub-io / manifests

A repository for Kustomize manifests
Apache License 2.0
8 stars 21 forks source link

WIP: KF 1.5 OpenShift stack #83

Closed LaVLaS closed 2 years ago

LaVLaS commented 2 years ago

Which issue is resolved by this Pull Request: Resolves #

Description of your changes:

Checklist:

openshift-ci[bot] commented 2 years ago

@LaVLaS: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/manifests/blob/v1.3-openshift/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VaishnaviHire commented 2 years ago

Shouldn't this PR be against the v1.4.0-rc.2-openshift branch ?

LaVLaS commented 2 years ago

Good catch. I didn't check base branch when creating the PR but this is based on top of upstream v1.5-branch -> v1.5-branch-openshift