opendatahub-io / model-registry-operator

Apache License 2.0
3 stars 17 forks source link

feat: add openshift serving certs to metrics endpoint, fixes RHOAIENG-1828 #120

Closed dhirajsb closed 1 month ago

dhirajsb commented 1 month ago

Description

Add openshift serving certs to metrics endpoint Fixes RHOAIENG-1828

How Has This Been Tested?

Locally applied the generated ODH config from the ODH overlay and verified the following:

Verified metrics can be retrieved after creating clusterrolebinding from another pod serviceaccount to metrics-reader role.

Merge criteria:

dhirajsb commented 1 month ago

@tarilabs need to merge this before creating the next MR release for ODH 2.16

tarilabs commented 1 month ago

@dhirajsb you wanted me to perform the release train of MR by Monday, but seems this one is holding the release based on your https://github.com/opendatahub-io/model-registry-operator/pull/120#issuecomment-2264511461. Please advise.

dhirajsb commented 1 month ago

@tarilabs merged this change since I was waiting on a platform PR merge as well. We are ok to do the MR release now.