feat: add annotations for external service host and port in MR service, fixes RHOAIENG-11092 - Githubissues

opendatahub-io / model-registry-operator

Apache License 2.0

3 stars 17 forks source link

feat: add annotations for external service host and port in MR service, fixes RHOAIENG-11092 #125

Closed dhirajsb closed 1 month ago

dhirajsb commented 1 month ago

Description

Add annotations for external service host and port in k8s MR service Fixes RHOAIENG-11092

How Has This Been Tested?

Tested istio and non-istio samples to look for annotations being set correctly in istio sample only.

Merge criteria:

[X] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

dhirajsb commented 1 month ago

@mturley I added a default annotation routing.opendatahub.io/external-address for dashboard and protocol specific annotations routing.opendatahub.io/external-address-rest, and routing.opendatahub.io/external-address-grpc for any other clients looking for protocol specific address.