opendatahub-io / model-registry-operator

Apache License 2.0
3 stars 19 forks source link

feat: switch from go build to make build in dockerfile #131

Closed Al-Pragliola closed 2 months ago

Al-Pragliola commented 2 months ago

Description

Switched from go build to make build in the Dockerfile, also I have added the minimal needed COPY to make the command work, also I had to switch to USER root to make sed work, as I had the following error:

# sync model-registry image
sed "s|quay.io/opendatahub/model-registry:.*|quay.io/opendatahub/model-registry:latest|" -i ./config/manager/manager.yaml
sed: couldn't open temporary file ./config/manager/sedmgPg4K: Permission denied

(solved by following this issue https://github.com/containers/podman/issues/5197)

How Has This Been Tested?

run make docker-build locally

Merge criteria: