Closed lampajr closed 9 months ago
I think line image: controller
as part of https://github.com/opendatahub-io/model-registry-operator/pull/38 will do the same, it changes the manager.yaml
container image to a placeholder controller
that can be replaced during the deploy.
So I think we can close this PR :)
Fixes https://github.com/opendatahub-io/model-registry-operator/issues/24
Description
Makes the operator image correcly overridable using
make deploy IMG=<...>
script.The issue is here:
$(KUSTOMIZE) edit set image controller=${IMG}
wherecontroller
is not the actual image inmanager.yaml
, and as per my understanding the kustomize edit should have the following structure:Therefore replacing
controller
with the actual imagequay.io/opendatahub/model-registry-operator
should do the trick.How Has This Been Tested?
make deploy IMG=quay.io/opendatahub/model-registry-operator:main-4c04ff7
k describe pod/model-registry-operator-controller-manager-<...> -n model-registry-operator-system
Normal Pulling 56s kubelet Pulling image "quay.io/opendatahub/model-registry-operator:main-4c04ff7"
Alternatively:
cd config/manager && kustomize edit set image quay.io/opendatahub/model-registry-operator=quay.io/opendatahub/model-registry-operator:main-4c04ff7
config/manager/kustomization.yaml
should contain the following changes:kustomize build .
orkustomize build config/manager
depending if you are in the target directory or in the root.:main-4c04ff7
version of the operator image:Merge criteria: