opendatahub-io / model-registry-operator

Apache License 2.0
3 stars 19 forks source link

Explicit model-registry proxy MLMD gRPC port param #27

Closed tarilabs closed 12 months ago

tarilabs commented 1 year ago

Resolves #26

Description

Without explicit params the deployed MR would try to connect to MLMD gRPC to localhost:8081 See: https://github.com/opendatahub-io/model-registry/blob/04aa36605d43a9884b06fb9cd68ce46a14b6b717/cmd/proxy.go#L77-L80

AFTER

Now connects to port 9090 accounting for template values:

How Has This Been Tested?

Ad-hoc built operator in another quay organization and deployed with this change. Deploys as expected:

Screenshot 2023-11-13 at 11 16 24 Screenshot 2023-11-13 at 11 16 40

NOTE: notice the I1113 10:05:11.181255 1 proxy.go:34] MLMD server localhost:9090 line, to connect to the expected defaults.

Manually created OCP Route (accounting for #19 by defining it manually):

Screenshot 2023-11-13 at 11 29 46

Then can be used:

Screenshot 2023-11-13 at 11 17 48

Merge criteria: