feat: add istio config and odh overlay

opendatahub-io / model-registry-operator

Apache License 2.0

3 stars 19 forks source link

feat: add istio config and odh overlay #64

Closed dhirajsb closed 7 months ago

dhirajsb commented 8 months ago

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

dhirajsb commented 7 months ago

@rareddy thanks for testing this PR. Since it's working in a few different clusters now, can we approve this PR so we can do a MR release for odh 2.10.1?

rareddy commented 7 months ago

@dhirajsb is is your fork syned with this PR, I tested your fork, not this PR, as I needed the mysql-tls stuff

dhirajsb commented 7 months ago

Yes, this PR is based on the same fork branch ossm-config. I used another branch test-ossm (based on ossm-config) to just create a custom manifest with the test MR operator image. I didn't want to pin the operator image in the odh overlay in this PR branch to the test docker image.

dhirajsb commented 7 months ago

Integration testing this in our kind cluster CI with Istio is going to be a non-trivial amount of work. I've created an issue for that https://issues.redhat.com/browse/RHOAIENG-5124 for the future.