fix: add secure mysql db samples, fixes RHOAIENG-5436

opendatahub-io / model-registry-operator

Apache License 2.0

3 stars 17 forks source link

fix: add secure mysql db samples, fixes RHOAIENG-5436 #95

Closed dhirajsb closed 4 months ago

dhirajsb commented 4 months ago

Description

Added secure mysql db samples without and with istio tls Fixes RHOAIENG-5436 Fixes RHOAIENG-6713

How Has This Been Tested?

Tested samples manually, by first creating the DB cert using make certificates and then the appropriate kubectl apply -k command.

Merge criteria:

[X] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

dhirajsb commented 4 months ago

@nehachopra27 @tonyxrmdavidson we should use these secure mysql samples in QE tests as that's closer to what users will deploy in production.

rareddy commented 4 months ago

Is there a procedure to update or rotate the certificates when they expire?
Is there a procedure for a user to bring in their custom certificates instead of self-generated?

Both could be just documentation details but be good to note for the users.

dhirajsb commented 4 months ago

Is there a procedure to update or rotate the certificates when they expire? Is there a procedure for a user to bring in their custom certificates instead of self-generated?

Good ideas, I'll add them to the readme. In general, these are just samples and users are not expected to use these exact DB configurations in production. The secure DB samples are there to test and demo model registry support for secure DB connections.