Closed VedantMahabaleshwarkar closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: VedantMahabaleshwarkar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@VedantMahabaleshwarkar Rather them maintaining manifest in opendatahub/manifests
folder could we simply maintain them inside /config
folder itself so that it would be more allign with the way we are maintaing manifest for odh-model-controller and kserve.
Description
odh-manifests/model-mesh/odh-modelmesh-controller
and put them inopendatahub/manifests
along with nessary changes to work with the new directory structureTesting
The testing for this PR is to be done along with the testing for this and this PR since they target the same set of overall changes. The ODH operator image has been built with the following changes :
quay.io/vedantm/odh-model-controller:remove-kserve-flag
which contains the changes for this PR.How Has This Been Tested?
ModelMesh testing
git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
cd opendatahub-operator
manifests_transition_mlserving
make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
opendatahub-operator-system
with the imagequay.io/vedantm/opendatahub-operator:latest
opendatahub
Kserve testing
git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
cd opendatahub-operator
manifests_transition_mlserving
make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
opendatahub-operator-system
with the imagequay.io/vedantm/opendatahub-operator:latest
opendatahub
Merge criteria: