opendatahub-io / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
3 stars 32 forks source link

move model-mesh to opendatahub/manifests #221

Closed VedantMahabaleshwarkar closed 1 year ago

VedantMahabaleshwarkar commented 1 year ago

Description

Testing

The testing for this PR is to be done along with the testing for this and this PR since they target the same set of overall changes. The ODH operator image has been built with the following changes :

How Has This Been Tested?

ModelMesh testing

Kserve testing

Note: Cleanup kserve CRDs before testing modelmesh

Merge criteria:

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/modelmesh-serving/blob/main/OWNERS)~~ [VedantMahabaleshwarkar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vaibhavjainwiz commented 1 year ago

@VedantMahabaleshwarkar Rather them maintaining manifest in opendatahub/manifests folder could we simply maintain them inside /config folder itself so that it would be more allign with the way we are maintaing manifest for odh-model-controller and kserve.

VedantMahabaleshwarkar commented 1 year ago

replaced by https://github.com/opendatahub-io/modelmesh-serving/pull/237