opendatahub-io / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
3 stars 32 forks source link

Sync kserve/main (v0.11.1) to odh/main #229

Closed heyselbi closed 1 year ago

heyselbi commented 1 year ago

Motivation

Sync kserve/main to odh/main. v0.11.1 tag points to the latest commit in kserve/modelmesh-serving:main.

Testing instructions

  1. git clone git@github.com:opendatahub-io/modelmesh-serving.git

  2. cd modelmesh-serving

  3. TAG=fast CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving CUSTOM_IMG=modelmesh-controller=quay.io/opendatahub/modelmesh-controller:pr-229 make deploy-mm-for-odh

  4. Check that the modelmesh controller deployment/pod has the correct image (shown in step 3). If not, patch it: oc patch deployment modelmesh-controller -n opendatahub --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/image", "value": "quay.io/opendatahub/modelmesh-controller:pr-229"}]'

  5. Check that the manager container of modelmesh-controller and of odh-model-controller show no error.

  6. TAG=fast CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving FORCE=true make deploy-fvt-for-odh

  7. Check that modelmesh-controller container, odh-model-controller container and runtime containers show no error.

  8. Clean up: C_MM_CTRL_KFCTL=true C_MM_TEST=true make cleanup-for-odh

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

Checklist items below are applicable for development targeted to both fast and stable branches/tags

heyselbi commented 1 year ago

/retest

heyselbi commented 1 year ago

/meow

openshift-ci[bot] commented 1 year ago

@heyselbi: cat image

In response to [this](https://github.com/opendatahub-io/modelmesh-serving/pull/229#issuecomment-1751589107): >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
heyselbi commented 1 year ago

/test all

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/modelmesh-serving/blob/main/OWNERS)~~ [VedantMahabaleshwarkar,heyselbi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment