Apply patch to remove empty string of caBundle

vaibhavjainwiz commented 8 months ago

Motivation

This change is to fix https://issues.redhat.com/browse/RHOAIENG-244.

Modifications

Empty string of caBundle in ValidationWebhookConfiguration causes cyclic calling of reconcilation for DataScienceCluster controller. With this PR I had removed the empty caBundle string from ValidationWebhookConfiguration. Similiar patch is already applied in KServe manifest but missing in ModelMesh-Serving.

Result

It should not impact any existing functionalities.

Testing Instruction

Clone the code changes
navigate to modelmesh-serving folder

create manifest

kustomize build config/overlays/odh > mm.yaml

Varify caBundle field should not present in ValidatingWebhookConfiguration resource.

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Unit tests pass locally
[ ] FVT tests pass locally
[ ] If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

vaibhavjainwiz commented 8 months ago

/retest

vaibhavjainwiz commented 8 months ago

This PR is depends on https://github.com/opendatahub-io/opendatahub-operator/pull/804

vaibhavjainwiz commented 7 months ago

/retest

vaibhavjainwiz commented 7 months ago

/test pr-image-mirror

danielezonca commented 7 months ago

Similiar patch is already applied in KServe manifest but missing in ModelMesh-Serving.

Well spotted, one of the question I had during 2.5 certification was indeed why KServe has no issue and this is the reason 👍

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielezonca, davidesalerno, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/modelmesh-serving/blob/main/OWNERS)~~ [danielezonca] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / modelmesh-serving