opendatahub-io / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
3 stars 31 forks source link

Fix Stack-based Buffer Overflow on protobuf #265

Closed Jooho closed 7 months ago

Jooho commented 7 months ago

chore: Fix Stack-based Buffer Overflow on protobuf on protobuf

https://security.snyk.io/vuln/SNYK-GOLANG-GOOGLEGOLANGORGPROTOBUFENCODINGPROTOJSON-6137908

Motivation

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

Checklist items below are applicable for development targeted to both fast and stable branches/tags

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/modelmesh-serving/blob/release-0.11.1/OWNERS)~~ [Jooho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jooho commented 7 months ago

build issue will be fixed with upstream PR(https://github.com/kserve/modelmesh-serving/pull/478)

Jooho commented 7 months ago

it turned out that the build issue only happened with release-0.11.1 so I created another PR (https://github.com/opendatahub-io/modelmesh-serving/pull/268)

Jooho commented 7 months ago

/retest