opendatahub-io / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
3 stars 32 forks source link

Cherry-pick the etcd fix to the release branch #306

Closed mholder6 closed 1 month ago

mholder6 commented 1 month ago

Motivation

Cherry-picked to fix as the previous resources in https://github.com/opendatahub-io/modelmesh-serving/pull/303 was too low and caused modelmesh deployments to fail. -- this pr made limit and request values higher in the etcd container.

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

Checklist items below are applicable for development targeted to both fast and stable branches/tags

VedantMahabaleshwarkar commented 1 month ago

pr is targeting the wrong branch

mholder6 commented 1 month ago

Fixed target branch thanks @VedantMahabaleshwarkar

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, mholder6, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/modelmesh-serving/blob/release-0.12.0-rc0/OWNERS)~~ [VedantMahabaleshwarkar,israel-hdez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
israel-hdez commented 1 month ago

/lgtm