opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 57 forks source link

Upgrade to python 3.11 to the major of the notebooks #460

Closed atheo89 closed 6 months ago

atheo89 commented 6 months ago

CI PR: https://github.com/openshift/release/pull/49912

Description

This PR introduce Python 3.11 to the major of the notebooks.

More Specifically:

Post Items:

  1. Update ImageStreams in case we move this it to 2024a (Upstream+Downstream)
  2. Update 2024a CI configuration (Upstream+Downstream) https://github.com/atheo89/release/blob/add-python11/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-2024a.yaml

NOTE: The CI integration is not merged yet, thus, please for your test, fork the PR and build the images by yourself. like: make jupyter-minimal-ubi9-python-3.11

How Has This Been Tested?

Merge criteria:

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 months ago

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images ec698368f0d14c2fe27fd42f181621c58608dba4 link true /test images
ci/prow/notebooks-e2e-tests ec698368f0d14c2fe27fd42f181621c58608dba4 link true /test notebooks-e2e-tests
ci/prow/runtime-intel-ml-ubi9-python-3-9-pr-image-mirror ec698368f0d14c2fe27fd42f181621c58608dba4 link true /test runtime-intel-ml-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-ml-ubi9-python-3-9-pr-image-mirror ec698368f0d14c2fe27fd42f181621c58608dba4 link true /test notebook-jupyter-intel-ml-ubi9-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atheo89 commented 6 months ago

This PR is out of Scope for now