search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 62 forks source link

Remove kfp_tekton from the testing notebooks #478

Closed atheo89 closed 7 months ago

atheo89 commented 7 months ago

Related to: https://issues.redhat.com/browse/RHOAIENG-4784

Description

The end-to-end tests in the notebooks repository are failing because the kfp_tekton library has been removed and replaced with odh-elyra.

Ref on CI test: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_notebooks/476/pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests/1771201766046568448#1:build-log.txt%3A518

Merge criteria:

jstourac commented 7 months ago

For reference - kfp-tekton removal in #467

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 7 months ago

/test notebooks-e2e-tests

openshift-ci[bot] commented 7 months ago

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/habana-notebooks-e2e-tests 9bdcdd2901b570c65876b5b226522cfdd7226723 link true /test habana-notebooks-e2e-tests
ci/prow/images 9bdcdd2901b570c65876b5b226522cfdd7226723 link true /test images
ci/prow/notebooks-e2e-tests 9bdcdd2901b570c65876b5b226522cfdd7226723 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).