opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

Adding Dockerfile for AMD based on Centos9 #507

Closed dibryant closed 3 months ago

dibryant commented 4 months ago

FIxes for https://issues.redhat.com/browse/RHOAIENG-4368

Description

Docker file for ROCM based on: https://github.com/ROCm/ROCm-docker/blob/master/dev/Dockerfile-centos-7-complete

How Has This Been Tested?

Merge criteria:

atheo89 commented 3 months ago

Great! Could you also address the code static analysis test failures?

harshad16 commented 3 months ago

tested these with : https://quay.io/repository/harshad16/amd-base?tab=tags Screenshot from 2024-05-20 18-08-41

openshift-ci[bot] commented 3 months ago

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror
ci/prow/runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror
ci/prow/runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror
ci/prow/runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror 10024604d1859652c2878846d3e1ec1a5633063b link true /test notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror
ci/prow/notebooks-e2e-tests c7040f00a3899a166531d7b51a7574b5a9afcf7b link true /test notebooks-e2e-tests
ci/prow/images c7040f00a3899a166531d7b51a7574b5a9afcf7b link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment