Fix the failing E2E tests

jstourac commented 4 months ago

This is an attempt to fix our E2E tests to avoid failures that are there now.

Description

This updates the expected version of TrustyAI pip package to what is expected on the image.

See my comment for more info.

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

jstourac commented 4 months ago

More changes should come - I'm not sure that e.g. this code is correct:

    elif echo "$(FULL_NOTEBOOK_NAME)" | grep -q "trustyai-ubi8"; then \
        $(MAKE) validate-ubi8-datascience -e FULL_NOTEBOOK_NAME=$(FULL_NOTEBOOK_NAME); \

Installed versions in datascience:

matplotlib = "~=3.7.5"
pandas = "~=2.0.3"

vs in trustyai image:

matplotlib = "~=3.6.3"
pandas = "~=1.5.3"

See e.g. here:

======================================================================
FAIL: test_version (__main__.TestMatplotlib)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/ipykernel_135/3123039794.py", line 156, in test_version
    self.assertEqual(actual_major_minor, expected_major_minor, "incorrect version")
AssertionError: '3.6' != '3.7'
- 3.6
?   ^
+ 3.7
?   ^
 : incorrect version
======================================================================
FAIL: test_version (__main__.TestPandas)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/ipykernel_135/3123039794.py", line 35, in test_version
    self.assertEqual(actual_major_minor, expected_major_minor, "incorrect version")
AssertionError: '1.5' != '2.0'
- 1.5
+ 2.0
 : incorrect version
----------------------------------------------------------------------

What is the answer here?

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 4 months ago

@jstourac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebooks-e2e-tests	b5c06518c5c5711e4dbfc9e7ba0258081658e9d8	link	true	`/test notebooks-e2e-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

atheo89 commented 4 months ago

Hello @jstourac :slightly_smiling_face: I opened a follow up pull request for the e2e tests, could you take a look once you are available? It is here: https://github.com/opendatahub-io/notebooks/pull/517 I collected all the prior tests (minimal & data science) under trustyAi one

opendatahub-io / notebooks