opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.16.0 #512

Closed codeflare-machine-account closed 4 months ago

codeflare-machine-account commented 4 months ago

:rocket: This is an automated Pull Request.

This PR updates the Pipfile to sync with latest Codeflare-SDK release.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@codeflare-machine-account: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/habana-notebooks-e2e-tests 18e78918902ec8b1bda1e48e1550a19b92ab81d4 link true /test habana-notebooks-e2e-tests
ci/prow/notebooks-e2e-tests 18e78918902ec8b1bda1e48e1550a19b92ab81d4 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jstourac commented 4 months ago

FTR - this is related to https://issues.redhat.com/browse/RHOAIENG-6338 (https://issues.redhat.com/browse/RHOAIENG-5085).

jstourac commented 4 months ago

BTW - each update like this also requires update in metadata for the affected image version of image streams that contain the codeflare-sdk installed. Right now its these lines:

I wonder whether it would make sense to make these changes part of the PRs like this already?

harshad16 commented 4 months ago

ack, we would do the imagestream annotation update in a separate PR. Merging this now.

jstourac commented 4 months ago

@harshad16 in such case, please link it with this one issue https://issues.redhat.com/browse/RHOAIENG-6271