Update coddeflare-sdk on imagestream annotations

atheo89 commented 3 months ago

Follow up to this PR https://github.com/opendatahub-io/notebooks/pull/512 Related to: https://issues.redhat.com/browse/RHOAIENG-6271

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 3 months ago

@jiridanek: changing LGTM is restricted to collaborators

In response to [this](https://github.com/opendatahub-io/notebooks/pull/515#pullrequestreview-2030901876): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jiridanek commented 3 months ago

CI falures is (known I presume) trustyai fail and intel image builds running out of space...

atheo89 commented 3 months ago

CI falures is (known I presume) trustyai fail and intel image builds running out of space...

Yep, about trusty i just opened a pr to include all the prior test inside trusty's test notebook, you may find it here: https://github.com/opendatahub-io/notebooks/pull/517

jstourac commented 2 months ago

Shall this be rebased/merged? :thinking:

openshift-ci[bot] commented 2 months ago

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test images`
ci/prow/notebooks-e2e-tests	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test notebooks-e2e-tests`
ci/prow/notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror	67e3894240198045e4ed9a3cf2516ae3675df2d2	link	true	`/test notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / notebooks