Separate Intel® CPU and GPU containers for PyTorch and TensorFlow images.

sharvil10 commented 5 months ago

Separate Intel® CPU and GPU containers.

Description

This PR separates Intel® CPU & GPU containers.
Removed Intel GPU containers.
Change the base image to base-ubi9-python-3.9 for jupyter images to reduce size.

How Has This Been Tested?

Used Makefile to test images and deployment

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 5 months ago

Hi @sharvil10. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

atheo89 commented 5 months ago

/ok-to-test

atheo89 commented 5 months ago

Hey @sharvil10, it seems like you'll need to update the CI to align with the new build structure as well.

Ref: https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 5 months ago

@sharvil10: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	f25b4454085d18a06fd397ddbbc84fdb2a06b500	link	true	`/test images`
ci/prow/notebooks-e2e-tests	f25b4454085d18a06fd397ddbbc84fdb2a06b500	link	true	`/test notebooks-e2e-tests`
ci/prow/runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror	8259dd7d495dd18bc73deda991634517de97e70e	link	true	`/test runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror`
ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror	8259dd7d495dd18bc73deda991634517de97e70e	link	true	`/test runtime-intel-tf-ubi9-python-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror	8259dd7d495dd18bc73deda991634517de97e70e	link	true	`/test notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror	8259dd7d495dd18bc73deda991634517de97e70e	link	true	`/test notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

sharvil10 commented 5 months ago

Hi, the decision to separate the CPU and GPU containers is still being discussed so we're closing this PR. Sorry about that.

opendatahub-io / notebooks