opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

Update trustyAI test_notebooks #517

Closed atheo89 closed 2 months ago

atheo89 commented 3 months ago

This is a follow up PR for this: https://github.com/opendatahub-io/notebooks/pull/510

Update trustyAI test_notebook to include the tests from minimal and datascience due to python package inconsistencies

Description

How Has This Been Tested?

Tested the ubi9 test_notebok.ipynb flavor in ODH using TrustyAI 2024.1 workbench

You should see the following results:

test_create_default_session (__main__.TestBoto3) ... ok
test_version (__main__.TestBoto3) ... ok
test_jupyter_version (__main__.TestDependenciesVersions) ... ok
test_nbdime_version (__main__.TestDependenciesVersions) ... ok
test_nbgitpuller_version (__main__.TestDependenciesVersions) ... ok
test_buffer_pool (__main__.TestKafkaPython) ... ok
test_session_timeout_larger_than_request_timeout_raises (__main__.TestKafkaPython) ... ok
test_version (__main__.TestKafkaPython) ... ok
test_matplotlib_figure_creation (__main__.TestMatplotlib) ... ok
test_version (__main__.TestMatplotlib) ... ok
test_array_creation (__main__.TestNumpy) ... ok
test_array_opeartions (__main__.TestNumpy) ... ok
test_array_statistical_functions (__main__.TestNumpy) ... ok
test_version (__main__.TestNumpy) ... ok
test_dataframe_creation (__main__.TestPandas) ... ok
test_dataframe_shape (__main__.TestPandas) ... ok
test_drop (__main__.TestPandas) ... ok
test_equal_dataframes (__main__.TestPandas) ... ok
test_index_out_of_bounds (__main__.TestPandas) ... ok
test_sampling (__main__.TestPandas) ... ok
test_unequal_dataframes (__main__.TestPandas) ... ok
test_version (__main__.TestPandas) ... ok
test_version (__main__.TestPythonVersion) ... ok
test_sklearn_dataset (__main__.TestSKLearn) ... ok
test_sklearn_train_test_split (__main__.TestSKLearn) ... ok
test_version (__main__.TestSKLearn) ... ok
test_scipy_integrate (__main__.TestScipy) ... ok
test_scipy_special (__main__.TestScipy) ... ok
test_version (__main__.TestScipy) ... ok
test_datafairness (__main__.TestTrustyaiNotebook) ... ok
test_fairnessmetrics (__main__.TestTrustyaiNotebook) ... ok
test_trustyai_version (__main__.TestTrustyaiNotebook) ... ok

Or should wait the CI to build the two trustyAI workbenches and then run podman run -it --rm -p 8888:8888 ${TrustyAI_CI_notebook} and run inside the test_notebook.ipynb (ubi8 & ubi9)

Merge criteria:

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 154bfc3b1686f7fb20473b41fd047c68ad9bd807 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).