Allow runtime script to cp the package from bin to Rpackage default path

dibryant commented 3 months ago

Fixes for https://issues.redhat.com/browse/RHOAIENG-3007

Description

Made a change to stop reinstallation of packages.

How Has This Been Tested?

Change buildconfig on cluster to uri: 'https://github.com/dibryant/notebooks' ref: fix Run the new build Open new notebook Install packages

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

atheo89 commented 2 months ago

Hey, just wanted to give a heads-up that I ran into a little snag on my R console. It seems like I hit an error when I tried to use the quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-518 image as BYON.

ERROR: dependencies ‘httpuv’, ‘later’, ‘promises’ are not available for package ‘shiny’
* removing ‘/opt/app-root/src/Rpackages/4.3/shiny’
Warning in install.packages :
  installation of package ‘shiny’ had non-zero exit status

However i have confused about what would be the lib path. Would be the /opt/app-root/src/Rpackages/4.3 or the /opt/app-root/bin/Rpackages/4.3?

If it is the /src why here https://github.com/dibryant/notebooks/blob/rstudio-fix/rstudio/c9s-python-3.9/Dockerfile#L34 we point to /bin ?

harshad16 commented 2 months ago

Hey, just wanted to give a heads-up that I ran into a little snag on my R console. It seems like I hit an error when I tried to use the quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-518 image as BYON.
ERROR: dependencies ‘httpuv’, ‘later’, ‘promises’ are not available for package ‘shiny’
* removing ‘/opt/app-root/src/Rpackages/4.3/shiny’
Warning in install.packages :
  installation of package ‘shiny’ had non-zero exit status

Not sure, why this issue came up. can you share some more details on this, as what command was run , which gave this error?

However i have confused about what would be the lib path. Would be the /opt/app-root/src/Rpackages/4.3 or the /opt/app-root/bin/Rpackages/4.3?

If it is the /src why here https://github.com/dibryant/notebooks/blob/rstudio-fix/rstudio/c9s-python-3.9/Dockerfile#L34 we point to /bin ?

In nginx we keep the path /opt/app-root/src/Rpackages/4.3, as in runtime we want rstudio to use this path for library as this path is persisted via PVC.

In dockerfile, we point the path to /opt/app-root/bin/Rpackages/4.3 due to same reason as above, as PVC mount, we need a path which doesn't get overridden. so we use bin, during build time we install everything in bin, and then only copy them to src, in runtime time this save the content and time.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 2 months ago

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebooks-e2e-tests	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test notebooks-e2e-tests`
ci/prow/images	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test images`
ci/prow/notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test notebook-jupyter-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test runtime-intel-pyt-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test runtime-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test notebook-jupyter-intel-tf-xpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test notebook-jupyter-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test runtime-intel-pyt-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test runtime-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror`
ci/prow/notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror	93d4a5762f57c74031dee90dd1648e5fc609f9b7	link	true	`/test notebook-jupyter-intel-tf-cpu-ubi9-py-3-9-pr-image-mirror`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

harshad16 commented 2 months ago

Merging this ahead. Thanks for the work :100:

opendatahub-io / notebooks