Extend CI image check to also runtime images

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

15 stars 51 forks source link

Extend CI image check to also runtime images #522

Closed jstourac closed 2 months ago

jstourac commented 2 months ago

Description

Extens the CI check for the images we reference in our metadata to also runtime-images.

https://issues.redhat.com/browse/RHOAIENG-7882

How Has This Been Tested?

Simply run: ./ci/check-runtime-images.sh on your local machine (jq and skopeo tool needed).

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 months ago

@jstourac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebooks-e2e-tests	29b1188e1967731f230d3a86acc6f36b93149f45	link	true	`/test notebooks-e2e-tests`
ci/prow/images	29b1188e1967731f230d3a86acc6f36b93149f45	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

jstourac commented 2 months ago

Hi guys, any opinions? Can this be moved forward so we have this check in our next release branch? Thanks for any comments or proposals for improvements! :slightly_smiling_face:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment