Update expected values for the Habana 2024a and 2023b images in CI

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

15 stars 51 forks source link

Update expected values for the Habana 2024a and 2023b images in CI #523

Closed jstourac closed 2 months ago

jstourac commented 2 months ago

Description

Update expected values for the Habana 2024a and 2023b images in CI.

https://issues.redhat.com/browse/RHOAIENG-7884

How Has This Been Tested?

Run ./ci/check-params-env.sh

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jstourac commented 2 months ago

One thing - I haven't go deep into when we should expect the -amd64 suffix in the openshift build name. If any of you know, please let me know, otherwise I'll dig into it.

jstourac commented 2 months ago

Rebased and updated based on the latest changes in the images - looks like we don't have any exception in the checked values anymore, good job :slightly_smiling_face:

atheo89 commented 2 months ago

Override the tests, because the #521 is still in progress. /override ci/prow/images /override ci/prow/notebooks-e2e-tests

/lgtm /approve

openshift-ci[bot] commented 2 months ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/523#issuecomment-2106836826): >Override the tests, because the #521 is still in progress. >/override ci/prow/images >/override ci/prow/notebooks-e2e-tests > >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89,harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment