Check commit id from commit.env file for the images in params.env file

jstourac commented 2 months ago

Description

This extends our current CI for checking the image references to also check the content of the commit ID we use.

https://issues.redhat.com/browse/RHOAIENG-7885

How Has This Been Tested?

Run ./ci/check-params-env.sh

Merge criteria:

This is waiting for these to be merged first:

522
523
524
[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 2 months ago

@jstourac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebook-amd-c9s-python-3-9-pr-image-mirror	eec887945c1efe93ce58cd3e717c7e75f09104b5	link	true	`/test notebook-amd-c9s-python-3-9-pr-image-mirror`
ci/prow/notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror	eec887945c1efe93ce58cd3e717c7e75f09104b5	link	true	`/test notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror`
ci/prow/notebooks-e2e-tests	4ccbcf9dd9605ae693fa077f73b64fc9abc9b819	link	true	`/test notebooks-e2e-tests`
ci/prow/images	4ccbcf9dd9605ae693fa077f73b64fc9abc9b819	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

jstourac commented 2 months ago

FTR - I'm not doing any changes to the image definitions, thus the test failures above aren't relevant to this PR.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / notebooks