Closed atheo89 closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@atheo89: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/images | ba9d85becafd4a2a5c0c3f341fa58b5fc371f6df | link | true | /test images |
ci/prow/notebooks-e2e-tests | ba9d85becafd4a2a5c0c3f341fa58b5fc371f6df | link | true | /test notebooks-e2e-tests |
Full PR test history. Your PR dashboard.
Close this in favor of https://github.com/opendatahub-io/notebooks/pull/532
Related to: https://issues.redhat.com/browse/RHOAIENG-6392
Description
This PR allow the extensions get installed after code-server start.
How Has This Been Tested?
Playground Cluster: https://rhods-dashboard-redhat-ods-applications.apps.dis-210nightly.osp.rh-ods.com/notebookController/spawner
bastion.dis-210nightly.osp.rh-ods.com:8443/modh/codeserver:v1
or alternativelybastion.dis-210nightly.osp.rh-ods.com:8443/modh/codeserver@sha256:b8b999bbcf86dcfcf1029ebb9f5fa77b58c9ef2fb75123a7b4d6643a2746f061
code-server-notebook
ImageStream by adding a new tag with the above image.background-installation
tagRunning
Merge criteria: