Intel AI Tools Images rebased

sharvil10 commented 4 months ago

This PR changes the base of the jupyter images of intel AI Tools from runtime images to the intel-gpu base images for TF and PyTorch and ubi9-python for Intel ML. This is done to remove the dependency on runtime images and reduce the size of the images.

Description

Intel AI Tools TF Jupyter image's base image changed to Intel GPU base image
Intel AI Tools PyTorch Jupyter image's base image changed to Intel GPU base image
Intel AI Tools ML Jupyter image's base image changed to Python UBI9 base image
Installation of Intel oneAPI basekit replaced with individual necessary components for Intel AI Tools PyTorch and TF Runtime images.

How Has This Been Tested?

Ran tests with make commands

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 4 months ago

Hi @sharvil10. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

atheo89 commented 4 months ago

/ok-to-test

sharvil10 commented 4 months ago

This PR on OpenShift release repo needs to be reviewed and merged for the tests to work. Basically it reverts the changes that were merged to test the split Intel AI Tools CPU GPU containers.

sharvil10 commented 4 months ago

/retest

sharvil10 commented 4 months ago

/retest

sharvil10 commented 4 months ago

@atheo89 @harshad16 the tests for Habana images are failing but that's independent of the changed made here. Could you please review this PR?

sharvil10 commented 4 months ago

/retest

atheo89 commented 4 months ago

Thank you @sharvil10 for your PR, I will move your changes to main branch. That's right the habana notebook failed builds are not related to your changes, i will override the tests in order you get your PR merged.

/override ci/prow/images /override ci/prow/notebooks-e2e-tests

/lgtm /approve

I am not sure but as a next step to update the intel imagestreams with the newly build images. For example here

openshift-ci[bot] commented 4 months ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/544#issuecomment-2152878518): >Thank you @sharvil10 for your PR, I will move your changes to main branch. >That's right the habana notebook failed builds are not related to your changes, i will override the tests in order you get your PR merged. > >/override ci/prow/images >/override ci/prow/notebooks-e2e-tests > >/lgtm >/approve > >I am not sure but as a next step to update the intel imagestreams with the newly build images. For example [here](https://github.com/opendatahub-io/notebooks/blob/main/manifests/overlays/additional/jupyter-intel-ml-notebook-imagestream.yaml#L26) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / notebooks